Skip to content

Refactor API endpoints

https://gitlab.raccoongang.com/aliens/prozorro.sale/procedure/blob/master/src/prozorro_sale/procedure/api.py#L227

Here we do 3 things:

  • load object from DB
  • call a method on this object
  • Question Model is created

IMHO it's better to refactor it to the following sequence:

  • Question Model is created
  • load object from DB
  • call a method on this object

This gives us a benefit of early validation error in case question object is not valid. Maybe we should review all API endpoints and refactor them to fail early to save some resources otherwise spend for loading objects from DB